Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use slugify instead of slug #132

Closed
wants to merge 1 commit into from
Closed

Use slugify instead of slug #132

wants to merge 1 commit into from

Conversation

davedoesdev
Copy link

Because of dodo/node-slug#82

slugify was fixed in simov/slugify@e8f8a69

@wesleytodd
Copy link
Collaborator

While I am not opposed to this change, in an effort to reduce any churn it might cause, can you make a case for why this matters?

The use case for this module does not care at all for a redos because it is a cli tool. I made my very simple case for this here, and am not sure anything has changed.

@davedoesdev
Copy link
Author

Nothing, apart from github's security spam. Feel free to close.

@wesleytodd
Copy link
Collaborator

Ok, will close. I brought this up to the people who matter, apparently something is coming soon to help with this kind of spam.

https://twitter.com/wesleytodd/status/1026253123449311232

@wesleytodd wesleytodd closed this Aug 6, 2018
@davedoesdev
Copy link
Author

That would be great, it would help all the way up the dependency chain.
Currently when I get a security alert, I step down the chain to the last responsive project.
Maybe that isn't a common response.

@wesleytodd
Copy link
Collaborator

Yeah, I think the it is a good response, even if it is not common. I do the same thing usually.

The problem is that the tooling is very broad in its messaging because it cannot tell if you are using the package in a vulnerable way, especially if it is deep in the dep tree. Hopefully in the future the tool maintainers can help here.

@wesleytodd
Copy link
Collaborator

To follow up, I just published v1.6.2 with the patched version of node-slug.

Fixed here: dodo/node-slug#82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants